search

basho / erlang_js

A linked-in driver for Erlang to Mozilla's Spidermonkey Javascript runtime.
Apache License 2.0
238 stars 88 forks source link

Fix R18 erlang:now() deprecation warning #49

Closed mkurkov closed 8 years ago

mkurkov commented 9 years ago

HI, here is simple fix to remove R18 warning about deprecated erlang:now().

hmmr commented 9 years ago

+1

zyro commented 9 years ago

+1

novabyte commented 9 years ago

+1

pichi commented 8 years ago

What is preventing pulling this request? It's half of year for two lines fix which effect doesn't escape from one function. It's ridiculous.

hmmr commented 8 years ago

@pichi Thanks for bumping this PR. There's no active development happening in erlang_js these days, and it keeps passing under radar while we are still stuck at OTP-16.

@mkurkov Can you rewrite it to use timer:tc/1, which seems to be a little more to the point? Like so:

{Elapsed, _ } = timer:tc(fun do_calls/2, [Ctx, Count]),
Elapsed / Count.
pichi commented 8 years ago

@hmmr You are right. This is a way better solution. See #55

JeetKunDoug commented 8 years ago

Will close this and get #55 merged. Thanks, and sorry for the delay in looking at the PR.