search

basho / erlang_js

A linked-in driver for Erlang to Mozilla's Spidermonkey Javascript runtime.
Apache License 2.0
238 stars 88 forks source link

Bz1007 inconsistent map phase behavior #5

Closed kellymclaughlin closed 13 years ago

kellymclaughlin commented 13 years ago

These changes along with the accompanying changes to riak_kv resolve the inconsistent handling of 'notfound' errors between erlang and javascript map functions. These changes adopt option number 2 that was outlined in the bugzilla ticket: all 'notfound' errors are passed to the map functions and may be handled there. In the case the errors are not handled by the map functions, the error output returned from using erlang and javascript functions in HTTP MapReduce queries are consistent now.

There is still more work to be done to cleanup and improve MapReduce error handling, but I found it to be out of scope of this ticket.

kellymclaughlin commented 13 years ago

After considering this for a while I have decided that there are still too many inconsistencies between the handling of notfound errors between erlang and javascript so I'm closing this pull request for now and will re-open when I resolve the inconsistencies more to my liking.