basho / erlang_js

A linked-in driver for Erlang to Mozilla's Spidermonkey Javascript runtime.
Apache License 2.0
238 stars 88 forks source link

Fix compilation issues with OTP > 18.3 #64

Open whitfin opened 7 years ago

whitfin commented 7 years ago

I'm not familiar enough with C preprocessor voodoo to figure out how to make the switch from erl_exit to erts_exit backwards compatible, so if anyone has any tips that would be great (having said that, OTP itself wasn't backwards compatible).

I actually think this project should just use it's own exit functions instead of relying on those in OTP because they're not actually meant to be public: https://github.com/erlang/otp/blob/9c013e2f9f7e32de38dc9640038aee1840d68e04/erts/emulator/drivers/common/inet_drv.c#L1398. It was changed without PR and broken in a minor version.

This is a retarget of #58.