Please add some repl tests to 1.4

basho / giddyup

Visual scorecard for riak_test.

http://giddyup.basho.com/

54 stars 12 forks source link

Please add some repl tests to 1.4 #143

Closed engelsanchez closed 9 years ago

engelsanchez commented 9 years ago

I am not sure anymore how to do it myself anymore. I see this one PR that added SQL statements to add a test: https://github.com/basho/giddyup/pull/142/files

I can give it a try if you give me some pointers.

Basically I would like to have a number of repl tests that are not in the 1.4 run, and would love to have them when 1.4.12 is out in the next few days:

repl_aae_fullsync
repl_aae_fullsync_custom_n
replication2_rt_sink_connection

Thanks!

seancribbs commented 9 years ago

@engelsanchez I see repl_aae_fullsync and replication2_rt_sink_connection in the 1.4.x scorecard. repl_aae_fullsync_custom_n seems to have a min_version of 2.0.0.

seancribbs commented 9 years ago

Ohhhhhhhh. This is a silly bug. It amounts to "1.4.4" < "1.4.10" == false. I'll have to think of a better fix.