search

basho / giddyup

Visual scorecard for riak_test.
http://giddyup.basho.com/
54 stars 12 forks source link

Add server sent events. #32

Closed cmeiklejohn closed 11 years ago

cmeiklejohn commented 11 years ago

@seancribbs

Obsoletes #31.

seancribbs commented 11 years ago

Let's redo this now that #38 is completed and ready for review.

cmeiklejohn commented 11 years ago

Rebased against master.

seancribbs commented 11 years ago

It might be nice to have some indication in the UI that a new item was received, like an alert or something?

seancribbs commented 11 years ago

We should also get on Revision 11 of data, given the changes from this week. https://github.com/emberjs/data/blob/master/BREAKING_CHANGES.md

cmeiklejohn commented 11 years ago

When you say alert, I really want to put an alert(); in. :fish:

cmeiklejohn commented 11 years ago

I'm going to do the revision 11 upgrade later as it requires an ember bump which breaks a large amount of the application.

cmeiklejohn commented 11 years ago

@joedevivo

You have to click a link to be prompted, but then you'll have webkit notifications for any new results being posted to GiddyUp.

If you ask me, not bad, for a human.

cmeiklejohn commented 11 years ago

Screen Shot 2013-01-04 at 5 36 19 PM

joedevivo commented 11 years ago

That's hot.

joedevivo commented 11 years ago

looks and works great. Can we add more information to the alert?

something like

GiddyUp: New ${Pass|Fail} on ${ScorecardShortName} hostname $Testname | $Backend | $Platform $HudsonQuote

cmeiklejohn commented 11 years ago

"On it." - Hudson

joedevivo commented 11 years ago

+1 for phat new alerts