search

basho / giddyup

Visual scorecard for riak_test.
http://giddyup.basho.com/
54 stars 12 forks source link

Clean up, and ensure we always load record into RA. #40

Closed cmeiklejohn closed 11 years ago

cmeiklejohn commented 11 years ago

This fixes a problem with SSE where a record doesn't show up if the association record-array already exists with a fixed set of identifiers.

cmeiklejohn commented 11 years ago

@seancribbs I think this addresses the results not showing up. I also can not reproduce the 'live' error locally at all, but it shouldn't be a problem because it will reconnect every 2 seconds per the spec.

cmeiklejohn commented 11 years ago

Tagging @joedevivo for review if he has time. Way to test: local up the scorecard, run a test and the bubble should colorize (or if you are viewing a test instance, you'll see a result added to the list.)

seancribbs commented 11 years ago

WFM now, no errors in the logs and I get the desktop notifications like a champ. I might be missing some image because I got a "broken image" icon next to the notification.

cmeiklejohn commented 11 years ago

:)

cmeiklejohn commented 11 years ago

OK to merge?

seancribbs commented 11 years ago

not bad for a human

Ready to merge.

cmeiklejohn commented 11 years ago

lolololololo glad you caught up on meme innovation while you were gone

cmeiklejohn commented 11 years ago

Merged && deployed.