Two issues with current implementation of "unlimited" expiry:
the goal of the unlimited option (expiry_minutes=0) was to have leveldb mark the write time on incoming records, but never use the time for expiry. expiry_minutes of zero would NOT add the write time in MemTableInserterCallback(), violating the desire result. Corrected.
expiry_minutes==0 was not properly tested for whole file delete decisions. It was possible for expiry_minutes==0 to cause files to be deleted just after being created. Corrected.
Two issues with current implementation of "unlimited" expiry:
the goal of the unlimited option (expiry_minutes=0) was to have leveldb mark the write time on incoming records, but never use the time for expiry. expiry_minutes of zero would NOT add the write time in MemTableInserterCallback(), violating the desire result. Corrected.
expiry_minutes==0 was not properly tested for whole file delete decisions. It was possible for expiry_minutes==0 to cause files to be deleted just after being created. Corrected.