Unbreak 32-bit build - Githubissues

basho / leveldb

Clone of http://code.google.com/p/leveldb/

BSD 3-Clause "New" or "Revised" License

408 stars 182 forks source link

Unbreak 32-bit build #242

Closed hmmr closed 2 years ago

hmmr commented 2 years ago

This PR:

replaces deprecated auto_ptr with unique_ptr;
drops some dead code (port/port_chromium.h is not present in the project and LEVELDB_PLATFORM_CHROMIUM is never defined);
enables building on 32-bit arches, by dropping workarounds in various add_and_fetch and dec_and_fetch and directly falling through to gcc built-ins. Specifically, x86, where it also passes the tests.

Eleveldb tests are passing.

martinsumner commented 2 years ago

Was the change to table_test.cc due to an intermittent test failure?

hmmr commented 2 years ago

It wasn't even intermittent (it was reliably failing all the times I ran the tests). https://github.com/basho/leveldb/pull/232 suggests it was failing all along. I was unable to dig deeper and find the root cause of it failing; I can only confirm that the upgrade of snappy didn't make it worse.