search

basho / node_package

RPM/Debian/FreeBSD/SmartOS/Solaris/OSX packaging templates for Erlang Nodes
Apache License 2.0
89 stars 63 forks source link

Pickup basho-patches in nodetool [JIRA: TOOLS-137] #189

Open sargun opened 9 years ago

sargun commented 9 years ago

Right now, when you run nodetool from node_package, it doesn't add basho-patches to the code path when running escript. This means that if you've patches any of core OTP, you must overwrite those files as opposed to simply dropping a replacement in basho-patches.

Basho-JIRA commented 9 years ago

Can this be prioritized in the next set of DevOps work?

_[posted via JIRA by Derek Somogyi]_

Basho-JIRA commented 8 years ago

pending feedback from Greg

_[posted via JIRA by David Andersen]_

Basho-JIRA commented 8 years ago

reviewed with Greg. need to sync up with Sargun again for additional info.

_[posted via JIRA by David Andersen]_

Basho-JIRA commented 8 years ago

This could probably done by adding something like this to the main/1 function in https://github.com/basho/node_package/blob/develop/priv/base/nodetool

true = code:add_pathz(filename:dirname(escript:script_name()) ++ "/../lib/basho-patches"),

The tricky part of this would be getting knowledge of where the basho-patches dir is. The above works for "relocatable releases" where the erts location is at the same directory level as the lib directory. Would have to do some thinking and investigating on where nodetool gets called from to get it passed in otherwise.

_[posted via JIRA by Drew Kerrigan]_