Use POSIX compatible shell and tools on Solaris

basho / node_package

RPM/Debian/FreeBSD/SmartOS/Solaris/OSX packaging templates for Erlang Nodes

Apache License 2.0

89 stars 63 forks source link

Use POSIX compatible shell and tools on Solaris #207

Closed kesslerm closed 7 years ago

kesslerm commented 7 years ago

The runner (a.k.a riak, riak-cs, etc) script sourced env.sh early on, before pivoting to running in a POSIX compliant shell. Pivoting first, and sourcing env.sh afterwards allows us to write the remainder of the script and any sourced scripts in a POSIX compliant way without breaking execution on Solaris 10.

kesslerm commented 7 years ago

Other scripts (e.g. riak-admin, search-cmd, etc.) also pull in env.sh. These will have to be modified in their respective repositories to also pivot to a posix compatible shell if this PR is applied.

kesslerm commented 7 years ago

Closing this PR for now. @JeetKunDoug liked the approach, but we decided to postpone until after the 2.2 release. #206 (TOOLS-345) was fixed by ensuring that env.sh could be pulled in by the default Solaris shell.