basho / node_package

RPM/Debian/FreeBSD/SmartOS/Solaris/OSX packaging templates for Erlang Nodes
Apache License 2.0
89 stars 63 forks source link

Use rebar raw dependency instead of dummy priv folder and app.src file #38

Open nivertech opened 11 years ago

nivertech commented 11 years ago

https://github.com/basho/rebar/pull/217#issuecomment-8230441

       %% Dependencies can be marked as 'raw'. Rebar does not require
        %% such dependencies to have a standard Erlang/OTP layout
        %% which assumes the presence of either
        %% "src/dependency_name.app.src" or "ebin/dependency_name.app"
        %% files.
        %%
        %% 'raw' dependencies can still contain 'rebar.config' and
        %% even can have the proper OTP directory layout, but they
        %% won't be compiled.
        %%
        %% Only a subset of rebar commands will be executed on the
        %% 'raw' subdirectories: get-deps, update-deps, check-deps,
        %% list-deps and delete-deps.
        {application_name, "",
         {git, "git://github.com/basho/node_package.git", {branch, "master"}},
         [raw]}]}.
jaredmorrow commented 11 years ago

I'm aware of the rebar features, but what would this provide for node_package? Using it the way we have it does not cause issues and does not force people to remember the [raw] flag.

nivertech commented 11 years ago

Just meaningful folder names - cosmetics. No need to pretend to be OTP app, which node_package is not. Feel free to close.

jaredmorrow commented 11 years ago

Oh gotcha, I didn't know if there was a bug. Yes cosmetically this repo could be a lot nicer. I would be affraid people would forget the [raw] and it would break right away for them, but maybe that's a bad reason to not change things around. I'll keep this open to think about it and to get other opinions if there are more out there.

So, are you using node_package in a project?

nivertech commented 11 years ago

Not yet, but I'd like to. There are few issues:

  1. You have no LICENSE file in the repo (I guess it's the same license as other basho OSS projects).
  2. I need to figure how to use it ;)
  3. I'll need to add support for Raspberian (version of Debian for RaspberryPi) and Angstrom Linux.

For now I just distribute self-contained .tar.gz file with self-contained OTP release - but having native OS packages would be nice.

jaredmorrow commented 11 years ago

I just added the LICENSE file on master, sorry I overlooked that. I'm trying to do a talk about packaging at EUC or another conference, so if that happens I'll have a lot of time to get a better readme/wiki/tutorial done.

nivertech commented 11 years ago

thanks, I'll be speaking at EUC - see you there.

jaredmorrow commented 11 years ago

Talk needs to get accepted first, and in that case, yes I will see you there.

On Mar 23, 2013, at 9:53 AM, Zvi notifications@github.com wrote:

thanks, I'll be speaking at EUC - see you there.

— Reply to this email directly or view it on GitHub.