search

basho / riak-erlang-client

The Riak client for Erlang.
Apache License 2.0
311 stars 188 forks source link

Add gset support #326

Closed russelldb closed 7 years ago

russelldb commented 7 years ago

This PR is not ready for merging, but I'm opening it for review. The rebase was difficult because of the refactoring out of the test code so I chose to merge the non-conflicting code and re-implement the remaining change.

I'd appreciate your eyes briefly @binarytemple-bet365

binarytemple-external commented 7 years ago

@russelldb - Branch comparison:

rdb/bet365/gsets...bet365:feature/bet365/gsets

/feature/bet365/gsets...basho:rdb/bet365/gsets

Checked it out, seems the same to me.

binarytemple-external commented 7 years ago

@russelldb Well the tests moved to their own file - riakc_pb_socket_test.erl - and the test ' {"add item to gset, twice"' is in there as expected.

russelldb commented 7 years ago

Thanks @binarytemple-bet365

I just made some small changes. Tests pass for me now, so I'm plus one on this

russelldb commented 7 years ago

+1

Ready to merge when gset support is merged in riak

russelldb commented 7 years ago

of course needs this PB branch https://github.com/basho/riak_pb/pull/209

russelldb commented 7 years ago

Closing. Missed the 2.2 boat, going in 2.3, see https://github.com/basho/riak-erlang-client/pull/327