basho / riak-erlang-client

The Riak client for Erlang.
Apache License 2.0
311 stars 188 forks source link

Compilation failing with version 20 #366

Closed sfilargi closed 6 years ago

sfilargi commented 6 years ago
===> Compiling _build/default/lib/riakc/src/riakc_pb_socket.erl failed
_build/default/lib/riakc/src/riakc_pb_socket.erl:2384: crypto:rand_bytes/1 is deprecated and will be removed in a future release; use crypto:strong_rand_bytes/1

Diffs to fix it:

--- a/rebar.config
+++ b/rebar.config
@@ -1,4 +1,4 @@
-{require_otp_vsn, "R15|R16|17|18|19"}.
+{require_otp_vsn, "R15|R16|17|18|19|20"}.

 {cover_enabled, true}.

@@ -9,7 +9,7 @@
     warnings_as_errors,
     {platform_define, "^[0-9]+", namespaced_types},
     {platform_define, "(?=^[0-9]+)(?!^17)", deprecated_now},
-    {platform_define, "^19", deprecated_19}
+    {platform_define, "^(19|20)", deprecated_19}
 ]}.

 {deps, [
bryanhuntesl commented 6 years ago

This needs to be closed - erlang-riak-client compiles and runs on Erlang 20 (with deprecation warnings)

bryanhuntesl commented 6 years ago

Relevant P/R were :

https://github.com/basho/riak-erlang-client/pull/365 https://github.com/basho/riak-erlang-client/pull/367