basho / riak-erlang-client

The Riak client for Erlang.
Apache License 2.0
311 stars 188 forks source link

Improve dialyzer types and checking #369

Open dhull opened 6 years ago

dhull commented 6 years ago

This pull request has three commits.

The first changes the specs for some riak_pb_socket to allow an atom (for a registered name) as an alternative to passing the pid.

The second and third are to get rid of the warnings produced by "make lint". In the second, some values that were declared as string were copied to record fields that were declared to accept only binary; I added a iolist_to_binary conversion to silence that warning. In the third, some code is testing for an undefined value for record fields that are declared to not allow undefined; I diabled dialyzer's no_match warning for that function.