basho / riak-erlang-client

The Riak client for Erlang.
Apache License 2.0
311 stars 188 forks source link

Add `node_confirms` option to PUT request #371

Closed russelldb closed 6 years ago

russelldb commented 6 years ago

And counter/datatype operations. NOTE: depends on riak-2.2.5 node_confirms feature.

Depends on: https://github.com/basho/riak_pb/pull/228

Depended on: https://github.com/basho/riak_kv/pull/1663

russelldb commented 6 years ago

Travis fails because it doesn't know to use the riak_pb branch that this pull request builds on, is there anyway around that? Change the rebar.config and then change it back before/after merging?

bryanhuntesl commented 6 years ago

Am I correct in understanding the fail is due to the referenced p/r (riak_kv/riak_pb) not having been merged yet ?

russelldb commented 6 years ago

right, but I wonder if we can just tell travis to use the right branch somehow?

bryanhuntesl commented 6 years ago

The only think I could think of would be to send up a .gitconfig with the aproprate aliases in place but that's probably more effort than it's worth. When we get on rebar3, profiles could also be an option; but again, a lot of effort. I'll try to get the two dependent p/r reviewed today.

russelldb commented 6 years ago

merged pb and tada, travis is super-green

bryanhuntesl commented 6 years ago

ship-it-squirrel