Closed ghost closed 6 years ago
Discovered sooooo many other things that broke on maven 3.5/java 9. I'm going to create a proper feature branch and make a larger pull request. people were lovin' those internal API's, powermock version is incompatible with Java 9 (hitting lots of illegal accesses), uh, pulling in random javax xml api to perform hex encoding, mocking stuff - then not hitting the mock, etc. Anyway bigger p/r coming very soon.
Firstly, in time honored tradition - the maven enforcer plugin crashes with a null pointer exception, compatibility hasn't been maintained by the Apache team in their latest product iteration. As far as I can see, the sole purpose of this plugin is to enforce the use of Maven 3.0 during builds - Maven 3.0 is obsolete btw.
Secondly, the enforcer is enforcing that folk use Maven 3.0 :
From the Maven project - "Apache Maven 3.5.2 is the latest release and recommended version for all users."
Thirdly:
Warnings as errors - warning wrt conversion/use of Long in
riak/client/core/query/timeseries/DescribeQueryResultParser.java
breaks the build - it's deprecated as of Java 9 (installed by default on OSX). IMHO - at this point in product life-cycle better to generate a warning and have folk build the project than fail on something that will be a (potential) issue come Java 10 (and it's debatable whether there's any point in keeping the Riak TS code anyway).Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
Pull requests that are small and limited in scope are most welcome.