search

basho / riak-nodejs-client

The Riak client for Node.js.
Apache License 2.0
72 stars 29 forks source link

Attached bucket type property operations to client object. #102

Closed brianedgerton closed 8 years ago

brianedgerton commented 8 years ago

@lukebakken I don't have your test environment set up, so I tested these changes with our integration work and everything appears to be working fine. So, I'm reasonably sure I didn't break anything obvious :smile: .

lukebakken commented 8 years ago

Thanks @brianedgerton

I opened PR #103 (CLIENTS-597) that adds your commit and a couple tests. I'll close this one and will get that one merged.

brianedgerton commented 8 years ago

@lukebakken I just got back from lunch and updated my dependency and my tests started breaking. In tracking it down it looks like the master branch and your v1.8.0 tag contain the correct source code, but the package published on npm is missing the code I submitted even though it has the right version number. Any idea what might have happened?

lukebakken commented 8 years ago

Something must have happened during the publish process. I'm looking into it now.

lukebakken commented 8 years ago

@brianedgerton I have published 1.8.1 to resolve this issue. Not sure what happened with the previous publish.

brianedgerton commented 8 years ago

Thanks! Tested and it works. Never seen that happen before when publishing to npm.

lukebakken commented 8 years ago

I have a script that does it (build/publish in the repo) and I think it barfed due to having commits to push or something like that. Not 100% sure.