search

basho / riak-nodejs-client

The Riak client for Node.js.
Apache License 2.0
72 stars 29 forks source link

Ready: Use new timeseries float/double apis #105

Closed alexmoore closed 8 years ago

alexmoore commented 8 years ago

Rework client to use new float/double api for cells. Swap "Numeric" column type for "Float".

alexmoore commented 8 years ago

Only question on this is whether we should allow numeric strings in the case when a column description is defined.

Example For a row that has 1 cell, SQL type Float.

  1. Create Storevalue command
  2. withColumns = [TsColumnType.Float]
  3. withRows = [ [ '4.5' ] ]

Storevalue command would then put '4.5' in the numericValue register of the cell only in this case.
Without the columns definition, it would store the string value '4.5' to the string cell register.

See https://github.com/basho/riak-nodejs-client/pull/105/files#diff-f26b0b0dee3b0c66618f90c8dfddf3bbR147.

lukebakken commented 8 years ago

:ship: :it: