Some code refactoring and optimizations #97 [JIRA: CLIENTS-591]

basho / riak-nodejs-client

The Riak client for Node.js.

Apache License 2.0

72 stars 29 forks source link

Some code refactoring and optimizations #97 [JIRA: CLIENTS-591] #97

Closed lukebakken closed 9 years ago

lukebakken commented 9 years ago

See original PR #94

Tested on Ubuntu 14 trusty. Updated README with correct git command for submodule initialization. Allow run a specific unit-test suite i.e. $ make unit-test SUITE=core Added more tests for RiakCluster.removeNode Refactored RiakCluster.removeNode for separation of concerns and better readability. Pass jshint checks.

lukebakken commented 9 years ago

Thank you @GabrielNicolasAvellaneda

GabrielNicolasAvellaneda commented 9 years ago

Cool :+1:

lukebakken commented 9 years ago

I apologize for letting this drop off of my radar. In the future if I don't get to one of your issues or PRs within 5 business days please comment and remind me :smile:

GabrielNicolasAvellaneda commented 9 years ago

Okay, no problem @lukebakken. Thank you!