Closed christophermancini closed 9 years ago
@christophermancini I think might even be a Major if you introduce BC
@debo So, the only things that changed interface wise, are headers are no longer relevant. So, instead of setting the Vclock header on the command builder or as a header on the object, you set it on the object. A few other small changes like that. The other major changes were with response objects, they no longer have anything to do with headers, they have a success flag, a code (http status code on http side), a message and then any command relevant properties.
I removed headers from the CRDT objects since I realized they were not even really used. Also, I left the constructor for Riak\Object intact, I just convert the headers there within the constructor to the new object members.
I am not sure its enough of a change to warrant a v3?
@christophermancini if you were to be strict about semver if there is BC then you bump the Major, even if the change is small. The last call is yours though.
@debo Fair enough, lets be strict about semver, this way no one can criticize us for it later. :)
@christophermancini as they say, better be safe then sorry ;)
@christophermancini build failures ... looks like something to do with code coverage?
@lukebakken not sure why it failed only for php5.6, I reran it and it worked fine. :question:
That is really strange that a re-run would fix it.
Looks fine to me :+1:
Hey @debo -- you've been incredibly helpful here! I'd love to thank you by sending some Basho stickers. Shoot me an email to mbrender /at/ basho.com!
In order to support PB, needed to decouple http code from the core lib and move it all to the API layer. Since this is a major change and potentially has breaking changes in it, this will be a brand new minor release for the PHP lib.