basho / riak-php-client

PHP clients for Riak
Apache License 2.0
160 stars 69 forks source link

Get Riak host/port from env, if available. [JIRA: CLIENTS-605] #105

Closed lukebakken closed 8 years ago

lukebakken commented 8 years ago

I've got code like the following in the Go and Node.js clients that reads the host and port for Riak from the environment, if present:

https://github.com/basho/riak-go-client/blob/master/globals_test.go#L39-L59

This facilitates running tests against a production Riak vs devrel.

lukebakken commented 8 years ago

Keep the default at 8098, of course. I won't have to edit tests/TestCase.php to run tests.

lukebakken commented 8 years ago

Running the php branch of riak-client-tools works too, so (shrug) :smile:

alexmoore commented 8 years ago

@lukebakken I knew that would come in handy for those that aren't fully virtualized :)

christophermancini commented 8 years ago

@alexmoore quiet you! :stuck_out_tongue_winking_eye: