Multiple improvements towards supporting PB

basho / riak-php-client

PHP clients for Riak

Apache License 2.0

160 stars 69 forks source link

Multiple improvements towards supporting PB #109

Closed christophermancini closed 8 years ago

christophermancini commented 8 years ago

Improved documentation of lib dependencies. Added constants for registers and flags. Added ping and stats endpoints. Reduced validation checks in http bridge class to lean more on json_decodes validation checks.

lukebakken commented 8 years ago

Tests pass:

lbakken@brahms ~/Projects/basho/riak-php-client (3.0.x=)
$ php vendor/bin/phpunit
PHPUnit 4.5.1 by Sebastian Bergmann and contributors.

Configuration read from /home/lbakken/Projects/basho/riak-php-client/phpunit.xml

...............................................................  63 / 119 ( 52%)
........................................................

Time: 22.33 seconds, Memory: 8.50Mb

OK (119 tests, 1364 assertions)

lukebakken commented 8 years ago

Seems fine to me, PHP is so stabby-backslashy that my eyes hurt.

christophermancini commented 8 years ago

Heh, I know the feeling, especially when I am working with ruby! :)

Thanks @lukebakken.