search

basho / riak-php-client

PHP clients for Riak
Apache License 2.0
160 stars 69 forks source link

Implement Riak TimeSeries support #120

Closed christophermancini closed 8 years ago

christophermancini commented 8 years ago

Time series tests can be run via phpunit:

./vendor/bin/phpunit TimeSeriesOperationsTest tests/functional/TimeSeriesOperationsTest.php

lukebakken commented 8 years ago

Tests pass against Riak TS 1.3. I'm using this php version:

$ php --version
PHP 7.0.6 (cli) (built: May  1 2016 07:39:38) ( NTS )
Copyright (c) 1997-2016 The PHP Group
Zend Engine v3.0.0, Copyright (c) 1998-2016 Zend Technologies
lukebakken commented 8 years ago

@alexmoore care to look too?

alexmoore commented 8 years ago

Also, I didn't see it in the tests, but do we have integration tests for all the cell types? (Store, and query or fetch back)

christophermancini commented 8 years ago

@alexmoore Each command is covered using these set of rows which hit all of the types. https://github.com/basho/riak-php-client/blob/ts/tests/TimeSeriesTrait.php#L47