Do not encode binary/base64 command object

basho / riak-php-client

PHP clients for Riak

Apache License 2.0

160 stars 69 forks source link

Do not encode binary/base64 command object #123

Closed benscott closed 8 years ago

benscott commented 8 years ago

Proposed fix for #122 (CLIENTS-698) (CLIENTS-918) - Not encoding binary data before submission to Riak.

christophermancini commented 8 years ago

@benscott thanks for the submission and I can see how this might be a problem. Would you be willing to write a unit / functional tests where appropriate to ensure sending binary and base64 data is properly handled? Once you have tests and they pass, I will approve this PR.

christophermancini commented 8 years ago

Hey @benscott, as you may have noticed, I expanded upon the work you contributed and opened #131 (CLIENTS-747). So I am going to close this PR. Any feedback / concerns you have, please post on the new PR. Thanks!