search

basho / riak-php-client

PHP clients for Riak
Apache License 2.0
160 stars 69 forks source link

responseHeaderCallback is truncating datetime-related header fields [JIRA: CLIENTS-948] #128

Closed kodekraft closed 7 years ago

kodekraft commented 8 years ago

Header fields like Last-Modified, are being truncated incorrectly due to the colon character associated with datetime fields. The explode function delimiter is set to the colon to parse the header key, and header value but is truncating any header values that have a colon character in it.

Found in: basho/riak/src/Riak/Api/Http.php:607

A proposed fix would be to change that line to:

list ($key, $value) = explode(':', $header, 2);
christophermancini commented 8 years ago

I will check into this issue, thanks for reporting it.

christophermancini commented 7 years ago

@heylarson Thanks again for all your contributions to the library. I fixed this bug in #140. Let me know if it doesn't resolve your issue.

kodekraft commented 7 years ago

Looks good!