Binary, base64 and none encoding

basho / riak-php-client

PHP clients for Riak

Apache License 2.0

160 stars 69 forks source link

Binary, base64 and none encoding #131

Closed christophermancini closed 7 years ago

christophermancini commented 7 years ago

To address #122 (CLIENTS-698) (CLIENTS-918), I consumed PR #123 (thanks @benscott!) and expanded upon it to offer better support overall when working with binary and base64 objects on the HTTP interface.

christophermancini commented 7 years ago

@benscott & @mablo can you review to determine if this PR looks good and meets your needs?

lukebakken commented 7 years ago

Does the Travis build depend on #132 (CLIENTS-756) for this PR?

lukebakken commented 7 years ago

Other than unhappy Travis, :+1:

christophermancini commented 7 years ago

Yes, #132 (CLIENTS-756) switches over to using PackageCloud as the source of Riak. Travis's version of Riak as a service is outdated and does not contain Preflist support. :/