search

basho / riak-php-client

PHP clients for Riak
Apache License 2.0
160 stars 69 forks source link

Add client for Riak 1.4.x compatibility and ability to list keys #147

Closed robocoder closed 7 years ago

robocoder commented 7 years ago

Changes to get https://github.com/doctrine/cache/issues/206 tests passing in my environment.

christophermancini commented 7 years ago

Hi @robocoder, thanks for the submission! I had not added ListKeys / Objects prior to today because I was concerned about the performance risks between PHP and Riak, but it is something we can add to support your needs. Just want to add some words of caution to it.

W.r.t. Riak 1.4 support, I spent some time discussing this with my team and we just can't add support for this within this lib as 1.4 support has ended. My recommendation here is if you feel 1.4 support for Doctrine Cache is a requirement, then create a new repository with the API bridge class in it similar to how I have done for PB support.

Also if you choose to support 1.4, you want to be mindful of things within the Http1 bridge that are not compatible with 1.4, e.g. TimeSeries and CRDT commands.

robocoder commented 7 years ago

Ok. I'll update the PR.