search

basho / riak-php-client

PHP clients for Riak
Apache License 2.0
160 stars 69 forks source link

Fix error "preg_replace(): The /e modifier is deprecated, use preg_repla... #71

Closed dionx closed 10 years ago

dionx commented 10 years ago

...ce_callback instead"

allinora commented 10 years ago

Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /library/3rdparty/riak-php-client/src/Basho/Riak/Utils.php on line 239

Thanks for looking into it.

Darkflib commented 10 years ago

Also affects the PHP HHVM engine (5.5 compat)

HipHop Notice: Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /root/vendor/basho/riak/src/Basho/Riak/Utils.php on line 239

Darkflib commented 10 years ago

Confirmed that normal functionality is not broken for a basic use case under HHVM: HipHop VM v2.3.3 (rel) Compiler: tags/HHVM-2.3.3-0-ge8141ac49daccb63e36e19757ad7efb1a3c358a1 Repo schema: 3611ac7b71cd8fc75eafccd700038cb9eb272b95

Warnings don't appear with change and functionality is the same for my test script.

kuenishi commented 10 years ago

Test passed for me. Thanks!