returnbody [JIRA: CLIENTS-87]

basho / riak-php-client

PHP clients for Riak

Apache License 2.0

160 stars 69 forks source link

returnbody [JIRA: CLIENTS-87] #72

Closed eveiga closed 9 years ago

eveiga commented 10 years ago

Hello!

I'm working with a bucket that has last_write_wins = true. This is a special use-case and I don't need the vclock info returned by each PUT/POST action.

I see that you are forcing the returnbody argument to always be true: https://github.com/basho/riak-php-client/blob/master/src/Basho/Riak/Object.php#L606

That should be configurable, maybe a new parameter in the store method. What do you think? I'm willing to contribute with a pull request.

Best regards

kuenishi commented 10 years ago

Yeah there seems to be no reason for forcing returnbody being true. I'll be happy to review your contribution.

christophermancini commented 9 years ago

Completed the change for 1.4.x. Will include as part of the 2.x rewrite.

Basho-JIRA commented 9 years ago

Work complete.

_[posted via JIRA by Christopher Mancini]_

Basho-JIRA commented 9 years ago

Chris -

So the GH ticket is closed. Does that mean we can resolve this, too?

_[posted via JIRA by Brett Hazen]_