search

basho / riak-python-client

The Riak client for Python.
Apache License 2.0
321 stars 183 forks source link

Do not use deprecated argument `verbose` in namedtuple #530

Closed romuloceccon closed 6 years ago

romuloceccon commented 6 years ago

Argument verbose to nametuple constructor was deprecated in Python 3.3, and was removed in Python 3.7.

This PR fixes the issue with Python 3.7 where trying to import riak raises an exception with message TypeError: namedtuple() got an unexpected keyword argument 'verbose'.

bryanhuntesl commented 6 years ago

Seems to have failed travis check - I'm going to run it on my travis fork

bryanhuntesl commented 6 years ago

Failing because the code formatting check utility (flake8) behavior has become more strict.

See this issue for extended (yawn) debate as to what does or doesn't constitute legitimate code - https://github.com/PyCQA/pycodestyle/issues/703

Any of our builds will now fail due to this change - until we get permanent maintainers involved - I suggest code is better than beautifully formatted flake8 compliant non-code.

I recommend we comment out the following line of travis.yml change to skip the flake8 testing.

https://github.com/basho/riak-python-client/blob/a190e871eabf2f42df40c62e888282848b9b8505/.travis.sh#L4

I've done so and now have passing builds

@martincox any thoughts ?

bryanhuntesl commented 6 years ago

Actually, we can do it a little bit cleaner - I've disabled those two specific style checks on the following PR #531 - if it passes we can merge it in first.

nickkeers commented 6 years ago

Thanks @romuloceccon - I'll get it merged as soon as we can get travis working!

romuloceccon commented 6 years ago

You're welcome, @nickkeers. Travis will only work again with both this and #531 merged in. Let me know if you want me to rebase my branch over bryanhuntesl@patch-1 (it's currently based on master).

nickkeers commented 6 years ago

@romuloceccon No worries, I'll just merge as it makes sense to me!