basho / riak

Riak is a decentralized datastore from Basho Technologies.
http://docs.basho.com
Apache License 2.0
3.94k stars 536 forks source link

extend schema for console and error log #902

Closed joecaswell closed 5 years ago

joecaswell commented 7 years ago

make console and error log size, rotation, and keep configurable in riak.conf

Currently these are hardcoded in the schema. Advanced.config requires specifying a full handlers block that includes all settings for all log files in order to modify them.

Add 6 configuration points: log.console.size log.console.rotation log.console.rotation.keep log.error.size log.error.rotation log.error.rotation.keep

thumbot commented 7 years ago
jhc-schema-lager-rotation bb8a581 :arrow_right: develop 109e618 :white_check_mark: completed
Looks good! :+1:
:white_check_mark: MERGE

> Started at: 2017-04-02 23:20 > Duration: 1 seconds. > Result: OK > Message: Merge Success: jhc-schema-lager-rotation bb8a581c11e5a40705402504bc152aecd7929a3b onto target branch: develop 109e61812e8cd1014e5439cc33b72c904144fe39 > Exit Code: OK > :page_facing_up:

``` Merge made by the 'recursive' strategy. apps/riak/test/riak_schema_test.erl | 18 +++++--- rel/files/riak.schema | 84 +++++++++++++++++++++++++++++++++---- 2 files changed, 87 insertions(+), 15 deletions(-) ``` --------------------------------------------------
joecaswell commented 7 years ago

Absolutely correct, that should have been mapped to lager.handlers. The way it was, if it were the only setting specified, it may be been ignored. The tests passed because the translation functions pull the settings by the riak.conf name, not their mapped name.

bsparrow435 commented 7 years ago

+1