search

basho / riak

Riak is a decentralized datastore from Basho Technologies.
http://docs.basho.com
Apache License 2.0
3.94k stars 536 forks source link

Add repl dependency #927

Closed martincox closed 6 years ago

martincox commented 6 years ago

Added dependency for riak_repl and various rel config. Also reverted back to previous tag for YZ.

russelldb commented 6 years ago

Does this mean we're dropping SNMP and JMX?

russelldb commented 6 years ago

Also, why not just take open the riak_ee repo and make that the default Riak?

martincox commented 6 years ago

No, this was just putting repl into open-source Riak. If there's an immediate need for it, let's add in the other components too. Any idea how widely used they are, if at all?

On the repo point, seemed less effort to add repl to to OSS Riak than to open up the private repo. It made more sense to keep it around - more issues, more activity, more forks, plain Riak over EE. There's not much in it really.

russelldb commented 6 years ago

There's some missing vars from vars.config and dev_vars.config for the cluster manager port and IP. That aside it looks ok, but I haven't taken the time to build and test it yet.

Need to make a decision about jmx and snmp I guess. My feeling is that the next release should contain them, but deprecated, and then they can be removed after that.

russelldb commented 6 years ago

Saying that, I added repl, jmx, and snmp to a OS Riak in the NHS fork and now Riak needs Java/Maven. Maybe you're right to add only repl.