search

basho / riak

Riak is a decentralized datastore from Basho Technologies.
http://docs.basho.com
Apache License 2.0
3.94k stars 536 forks source link

Add riak_repl.schema. #930

Closed firvida closed 5 years ago

firvida commented 6 years ago

This way replication can be configured using riak.conf. Partially reverts 8666c506954bd3b926a9b2c9d50b843c26b014fe.

russelldb commented 6 years ago

Sorry, just saw this now. Do you know if this fixes https://github.com/basho/riak/issues/940 ?

If so, can you re-point the PR at develop-2.2?

bryanhuntesl commented 6 years ago

I wonder if we could go even further than this and make the advanced.config completely empty by default - the lager configuration section is, as far as I can tell, superfluous.

It was added by @bsparrow435 back in 2016 but I can't see any reference to it anywhere in the code.

Everyone seems to be copy-n-pasting that block, but I'm smelling a potential cargo-cult.

bryanhuntesl commented 6 years ago

Nice fix +1

martincox commented 5 years ago

The repl schema is copied over in develop-3.0 by way of the cuttlefish plugin schema discovery, so this isn't really required anymore.