search

basho / riak

Riak is a decentralized datastore from Basho Technologies.
http://docs.basho.com
Apache License 2.0
3.93k stars 534 forks source link

Fixes for testing dependencies; travis #976

Open llelf opened 5 years ago

llelf commented 5 years ago

Not all tests pass. At least some of them because they are being run as a different profile¹. Ideas?

¹) https://github.com/basho/riak/blob/8dcae40c548d2bed16a5d3dc60df78f72bebb02b/Makefile#L59

ThomasArts commented 5 years ago

The problem is not so much the profile as that some tests have hard coded paths. With the profile deptests the idea was to test each riak dependency separately. That works reasonable, as long as the paths are not wrong.

It seems really easy to add travis. Possibly we should add travis just for ./rebar3 eunit to run the 5 unit tests (they pass). In the meanwhile, I work on getting the really failing tests and the tests that have wrong path to be fixed. After that, we add make test to this travis script. Agree?

llelf commented 5 years ago

It seems really easy to add travis

Yes, not having to build a custom OTP in travis helps tremendously ;-)

The problem is not so much the profile as that some tests have hard coded paths

Custom profile doesn’t help either. E. g. some dependencies have {erl_opts, [nowarn_export_all]} for their test profile.

I changed it too only run riak’s eunit tests for now.

llelf commented 5 years ago

Made more of dependencies tests work.

llelf commented 5 years ago

These deps are failing (https://travis-ci.org/llelf/riak/builds/535391932)

a b
cuttlefish
eper https://github.com/basho/riak_kv/pull/1689 ?
hyper
ibrowse
kv_index_tictactree
lager
mochiweb
syslog
webmachine
yokozuna https://github.com/basho/yokozuna/pull/757