Open martinsumner opened 4 years ago
@martinsumner it's a side effect of moving away from the runner in node_package. It's on my todo.
Sorry, what's the official stance on this? I find code in 3.0.1 referring to basho-patches
in riak-admin
and riak-debug
but the installed directory is only called lib/patches
and I am not seeing a lib/riak-patches
folder anywhere. If somebody can confirm what the official name is, I'm happy to update the above two files in /rel/files/bin/
to use the right name.
Some riak_test tests (e.g. ensemble_remove_node - https://github.com/basho/riak_test/blob/develop-2.9/tests/ensemble_basic2.erl) require a patch that survives restart using
rt_intercept:add_and_save/2
.This add and save uses the basho_patches folder, which is required to be in the code path of the node. However this is no longer in the code path in
develop-3.0
.The mkdir command in
rebar.config
https://github.com/basho/riak/blob/8a257eea9c5cd351aea41d0e59bf1b7149f52cd0/rebar.config#L76 has been switched to riak-patches. However, although switching that back to basho-patches will create the path inmake devrel
, it will not add the path to the code_path (i.e. if you start a node and then call code_get_path() fromriak remote_console
it is not included).Is this a relx issue?
@martincox might you be able to take a look?