basho / riak_api

Riak Client APIs
27 stars 46 forks source link

Fix dialyzer error #120

Closed raghavkarol closed 7 years ago

raghavkarol commented 7 years ago

Dialyzer sees the tuple {rpberrorresp, Message, 0} as the #rpberrorresp{} which is declared as

-record(rpberrorresp,
        {errmsg                 :: binary(),        % = 1
         errcode                :: non_neg_integer() % = 2, 32 bits
        }).

So, it gives a warning when the type of Message in the tuple above is not binary().

thumbot commented 7 years ago
rkarol/fix-dialyzer-error 5835b43 :arrow_right: develop 8cecaba :white_check_mark: completed
Looks good! :+1:
:white_check_mark: MERGE

> Started at: 2016-12-28 15:00 > Duration: 1 seconds. > Result: OK > Message: Merge Success: rkarol/fix-dialyzer-error 5835b430c37e61a872a20d124d1c884f2e6b56bc onto target branch: develop 8cecabaeeefa41ce6992a9b529fa8fe4e3b03ab4 > Exit Code: OK > :page_facing_up:

``` Updating 8cecaba..5835b43 Fast-forward (no commit created; -m option ignored) src/riak_api_pb_server.erl | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ``` --------------------------------------------------
lukebakken commented 7 years ago

Thank you, it would have taken me much longer to figure that out, if I ever would have.