folsom_sup already started as dep [JIRA: RIAK-1915]

[expelledboy]

Trying to push out a demo this week for use of riak_core in our company, but I cant get the workspace to start.

We build an application dependency tree using the release tools, which we flatten into an application boot order. This results in starting folsom, before riak_core. But riak_core_stat_sup later tries to start folsom_sup as its child?

init([]) ->
    Children = lists:flatten(
                 [?CHILD(folsom_sup, supervisor),
                  ?CHILD(riak_core_stats_sup, supervisor),
                  ?CHILD(riak_core_stat_calc_sup, supervisor)
                 ]),

    {ok, {{rest_for_one, 10, 10}, Children}}.

[seancribbs]

We run folsom as an 'included' application in riak_core. Modify your reltool.config to load it only, like so.

[sumerman]

Is there any particular reason to run folsom as an 'included' app? I believe It's very inconvenient for many riak_core users outside of basho. For instance I have to maintain workarounds in several internal projects.

[russelldb]

There was a reason. We'd have to look back through the commit messages to find it. We're removing folsom from riak_core soon. So your pain will be temporary.

[sumerman]

I see. Thank you for the response.

[emauton]

This is making it hard to start other folsom-dependent applications that have normal application dependencies, since I can't see a clean way to tell the dependent application that folsom is "sort of already started".

@russelldb, Any ETA on folsom's exit from riak_core?

@sumerman, it would be helpful if you briefly described your approach to working around this here. I guess for now I'll work around by forking & removing folsom entirely from the dependent application I'm using.

Thanks!

[sumerman]

@emauton we just write metrics code in a way compatible with both basho's and boundary's folsom and using basho's version in production.

[expelledboy]

@seancribbs We dont use reltool.config. I just read through all the commit messages, and the code, and I dont see why you cant just have a normal application dependency?

[seancribbs]

Recent riak_core uses exometer so I don't know that this is even relevant anymore. unsubscribed

[sumerman]

No longer relevant because of Exometer. I think it's safe to close this issue.

[expelledboy]

This is still relevant, as folsom_sup is still started as a child in the supervisor: https://github.com/basho/riak_core/blob/develop/src/riak_core_stat_sup.erl