search

basho / riak_core

Distributed systems infrastructure used by Riak.
Apache License 2.0
1.23k stars 391 forks source link

Add participate_in_2i_coverage riak option #917

Closed russelldb closed 6 years ago

russelldb commented 6 years ago

Allows marking of nodes 'down' in calculations for 2i coverage queries. In create_plan, it queries each node for the value of the participate_in_2i_coverage and treats those with the value set explicitly to false as 'down' for the calculation of avaiable vnodes.

See related riak_kv commit that adds a default value to the KV schema. This is an operator feature. The operator must bring down the node, change the config, and start the node, for it to have effect.

ghost commented 6 years ago

The structure looks OK - but I notice there are no tests for this new functionality - are they in a separate repository?

ghost commented 6 years ago

Duh, just read comments above.

russelldb commented 6 years ago

Don't you think maybe your comments about the schema from https://github.com/basho/riak_kv/pull/1664 should be on this PR?

ghost commented 6 years ago

I don't mind which PR is used to do it. the cuttlefish one could be merged in (to here) first.

russelldb commented 6 years ago

I don't understand.

ranisen commented 6 years ago

Looks ok for me.