basho / riak_cs

Riak CS is simple, available cloud storage built on Riak.
http://docs.basho.com/riakcs/latest/
Apache License 2.0
566 stars 95 forks source link

Robustification of Riak overload conditions #749

Open slfritchie opened 10 years ago

slfritchie commented 10 years ago

There are probably more bugs than simply this one in handling overload query results from the PB client:

2013-12-05 00:03:24.301 [error] <0.29110.498> gen_fsm <0.29110.498> in state waiting_command terminated with reason: no case clause matching {error,<<"overload">>} in riak_cs_manifest_fsm:handle_get_manifests/1 line 265 

Aside from fixing that function clause matching error, the rest of the app should be surveyed to make certain that CS does something sane in this temporary error case. Some amount of backoff-and-retry may be appropriate.

kellymclaughlin commented 10 years ago

Added this to the 1.5 milestone. It has come up a few times now so I think we should go ahead and fix it for the next release.

reiddraper commented 10 years ago

Has anyone started working on this?