basho / riak_dt

Convergent replicated datatypes in Erlang
Apache License 2.0
353 stars 71 forks source link

LWW Set ? #101

Closed benoitc closed 10 years ago

benoitc commented 10 years ago

Do you plan to provide an implementation of lwwset ?

russelldb commented 10 years ago

Nope, I hadn't planned it. Is it useful? Pretty simple to make. I can probably make one this weekend, unless you want to do it?

russelldb commented 10 years ago

I think I like the Roshi one as documented here - https://github.com/soundcloud/roshi

benoitc commented 10 years ago

I can try. But i need to become familiar with the code, so you will be probably faster than me ;)

russelldb commented 10 years ago

Well, I quite like the idea of making one like the Roshi one linked above, so I'll give it a go.

russelldb commented 10 years ago

Out of interest: what use is this CRDT? I can't help thinking it is larger than the ORSWOT (since once added an item is never really removed.)

russelldb commented 10 years ago

Should this LWWSet allow "dombstoning?" That is, removing an element that is not present?

russelldb commented 10 years ago

Spoke with Roshi author (https://github.com/soundcloud/roshi/issues/24) and they allow doomstones, so now riak_dt LWWSet does too.

russelldb commented 10 years ago

See https://github.com/basho/riak_dt/pull/102

cmeiklejohn commented 10 years ago

Closing; addressed by #102.