search

basho / riak_dt

Convergent replicated datatypes in Erlang
Apache License 2.0
353 stars 70 forks source link

Context operations #83

Closed russelldb closed 10 years ago

russelldb commented 10 years ago

Adds context / deferred operations to riak_dt_od_flag, riak_dt_orswot, riak_dt_map

Uses only a version vector as the context. Comments should help explain it (I hope.)

lenary commented 10 years ago

I made a test for ORSWOT, that i thought this code wouldn't do what a user might expect. Turns out it passes (and the user expectation is what's done), yay: https://gist.github.com/lenary/84f68e865f6a54e9832f

seancribbs commented 10 years ago

Generally I'm in-favor of this change. It greatly improves the semantics of map and orswot and reduces the size of the context considerably. There are a few nitpicks and holes that I have commented on. It's hard to ensure that I've covered everything, but the EQC for both map and orswot are really good now and I think I understood most every addition except for the parts that I have commented on.

I'm happy to do a final review as soon as you're ready.

seancribbs commented 10 years ago

Assigned 2.0-beta milestone.

seancribbs commented 10 years ago

+1 5aae7c4

russelldb commented 10 years ago

Is that +1 to the PR, or just that commit?

seancribbs commented 10 years ago

@russelldb Can't it be bolth?

russelldb commented 10 years ago

Heh, why not?! Ok, here goes, all 17 commits!