search

basho / riak_kv

Riak Key/Value Store
Apache License 2.0
653 stars 233 forks source link

Don't trigger node confirms failure if clock expected #1858

Closed martinsumner closed 1 year ago

martinsumner commented 1 year ago

When fetching an object for replication, enough nodes are found if the expected clock is true - but that might then fail on node_confirms. Don't generate the node_confirms response error if there has been a match on the expected clock.

martinsumner commented 1 year ago

https://github.com/basho/riak_test/pull/1374

martinsumner commented 1 year ago

https://github.com/basho/riak_kv/issues/1857

martinsumner commented 1 year ago

@yorkshire-steve - this has been resolved a different way to our discussion, as I considered that simply over-riding node_confirms in the request options for the specific fetch case to be a bit a fragile. Now the response failure for node_confirms is only generated when there has been no "Expected Clock" match