basho / riak_kv

Riak Key/Value Store
Apache License 2.0
651 stars 232 forks source link

Vnode write error reason is not propagated to FSM/client #837

Open engelsanchez opened 10 years ago

engelsanchez commented 10 years ago

Except for overload messages, for which we hacked a workaround overloading the returned request id from a vnode reply. We should generalize that so that any error reasons are propagated back. For example, now the write can fail due to a violation of the max siblings or max size constraints.

engelsanchez commented 10 years ago

Another unanswered question here: with the addition of the overload messages, special logic was added such that if a request failed and any of the vnodes returned an overload error, that overload error would be propagated to the client. With new known errors, there is the question of priority: what error to return if one vnode is overloaded and another hits the siblings maximum?