search

basho / riak_pb

Riak Protocol Buffers Messages
Apache License 2.0
71 stars 114 forks source link

avoid indiscriminate riak_ttb_codec:de_stringify #185

Closed hmmr closed 8 years ago

hmmr commented 8 years ago

This causes a regression where valid rows consisting of all integers get misinterpreted as a string and converted into binaries.

Only apply de_stringify to the top-level lists and to the innermost lists (which be the proper strings to be converted).

hazen commented 8 years ago

@hmmr I ran into exactly that same problem on Friday and spent great chunks of the weekend tracking it down. The original solution was a bit aggressive in it's conversion. I'll test this and see how it fares with our test suite.

lukebakken commented 8 years ago

@hmmr - please see #188, thanks

lukebakken commented 8 years ago

+1 87ef37c52d8eb56e0c4071db0dea870f3e7ed336

hazen commented 8 years ago

Thinking this is the path we want to go down. Let's just get the merge pain over. Geronimo!

hazen commented 8 years ago

👍 376bdbe