search

basho / riak_pb

Riak Protocol Buffers Messages
Apache License 2.0
70 stars 114 forks source link

Add gset support #209

Closed russelldb closed 7 years ago

russelldb commented 7 years ago

Rebased bet365 branch on develop-2.2. Eyes please @binarytemple-bet365. Particularly around is is gset_op=#gset_op or set_op=#gset_op? and should it be gset_value or set_value in the response??

binarytemple-external commented 7 years ago

@russelldb ha ha here we go again:

Rebased bet365 branch on develop-2.2. Eyes please @binarytemple-bet365. Particularly around is is >> gset_op=#gset_op or set_op=#gset_op? and should it be gset_value or set_value in the response??

I'd make it symmetric, if you link to a specific line of code it would be helpful. But in general terms, it would seem a good idea 'gset_op=#gset_op'

russelldb commented 7 years ago

Yup, I went through and we're standardised on gset_value and gset_op etc etc.

Tests pass, basic by hand smoke tests pass, riak-erlang-client integration tests pass. Plus One from me when the rest is ready.

Thanks @binarytemple-bet365 !

russelldb commented 7 years ago

Closed in favour of https://github.com/basho/riak_pb/pull/210