basho / riak_pb

Riak Protocol Buffers Messages
Apache License 2.0
70 stars 114 forks source link

Can't encode update response for a GSet update. [JIRA: RIAK-3157] #217

Closed alexmoore closed 7 years ago

alexmoore commented 7 years ago

When trying to return the GSset value after an update, I get the following:

Error processing incoming message: 
error:function_clause:[
  {riak_pb_dt_codec,
    encode_update_response,
    [
      gset, 
      [<<"user1">>, <<"user2">>,<<"user3">>], 
      undefined, 
      undefined, 
      [ 
        {map,riak_dt_map}, 
        {set, riak_dt_orswot}, 
        {counter, riak_dt_pncounter},
        {hll, riak_kv_hll},
        {gset, riak_dt_gset}
      ]
    ],
    [
      {file, "src/riak_pb_dt_codec.erl"}, {line,563}
    ]
  },
  {riak_kv_pb_crdt,
    process_update_response,
    2,
    [
      {file,"src/riak_kv_pb_crdt.erl"},{line,192}
    ]
  },
  ...
]

We'll need to add an update response handler like this for gsets: https://github.com/basho/riak_pb/blob/develop/src/riak_pb_dt_codec.erl#L565

lukebakken commented 7 years ago

Are there no tests for crdts in the erlang client?

alexmoore commented 7 years ago

There are, but there wasn't one for the GSet update response.