search

basho / riak_pb

Riak Protocol Buffers Messages
Apache License 2.0
71 stars 115 forks source link

Add GSET update response handling to riak_pb_dt_codec.erl #218

Closed alexmoore closed 7 years ago

alexmoore commented 7 years ago

Fixes #217 (RIAK-1903) (RIAK-2549) (RIAK-2990) (RIAK-3157).

thumbot commented 7 years ago

Thanks @alexmoore!

Settings ```yaml --- minimum_reviewers: 2 merge: true build_steps: - make clean - make deps - make compile - make test - make xref - make dialyzer org_mode: true timeout: 1800 ```
thumbot commented 7 years ago
am/fixes/gset-update-return-value 7cd82bb :arrow_right: develop 4541303 :white_check_mark: completed
Looks good! :+1:
:white_check_mark: MERGE

> Started at: 2017-01-04 15:10 > Duration: 1 seconds. > Result: OK > Message: Merge Success: am/fixes/gset-update-return-value 7cd82bb14fcf9ba30c16ebdfb22916b8c4fe890c onto target branch: develop 45413035823273a96ab0732610f25890986da88c > Exit Code: OK > :page_facing_up:

``` Updating 4541303..7cd82bb Fast-forward (no commit created; -m option ignored) src/riak_pb_dt_codec.erl | 6 ++++-- test/riak_pb_dt_codec_tests.erl | 14 +++++++++++++- 2 files changed, 17 insertions(+), 3 deletions(-) ``` --------------------------------------------------
:white_check_mark: MAKE_CLEAN

> Started at: 2017-01-04 15:10 > Duration: 1 seconds. > Result: OK > Message: OK > Exit Code: 0 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.am_fixes_gset-update-return-value.7cd82bb; make clean ==> develop.4541303.am_fixes_gset-update-return-value.7cd82bb (clean) ``` --------------------------------------------------
:white_check_mark: MAKE_DEPS

> Started at: 2017-01-04 15:10 > Duration: 1 seconds. > Result: OK > Message: OK > Exit Code: 0 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.am_fixes_gset-update-return-value.7cd82bb; make deps ==> develop.4541303.am_fixes_gset-update-return-value.7cd82bb (get-deps) Pulling hamcrest from {git,"https://github.com/basho/hamcrest-erlang.git", {tag,"0.3.0-basho"}} Cloning into 'hamcrest'... ==> hamcrest (get-deps) ``` --------------------------------------------------
:white_check_mark: MAKE_COMPILE

> Started at: 2017-01-04 15:10 > Duration: 4 seconds. > Result: OK > Message: OK > Exit Code: 0 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.am_fixes_gset-update-return-value.7cd82bb; make compile ==> hamcrest (compile) Compiled src/hamcrest.erl Compiled src/hamcrest_term.erl Compiled src/hamcrest_matchers.erl ==> hamcrest (post_compile) ==> develop.4541303.am_fixes_gset-update-return-value.7cd82bb (compile) Compiled src/riak_pb_kv_codec.erl Compiled src/riak_pb_codec.erl Compiled src/riak_pb_search_codec.erl Compiled src/riak_pb_messages.erl Compiled src/riak_pb_dt_codec.erl Compiled src/riak_dt_pb.erl Compiled src/riak_pb.erl Compiled src/riak_ttb_codec.erl Compiled src/riak_yokozuna_pb.erl Compiled src/riak_pb_ts_codec.erl Compiled src/riak_ts_pb.erl Compiled src/riak_search_pb.erl Compiled src/riak_kv_pb.erl ``` --------------------------------------------------
:white_check_mark: MAKE_TEST

> Started at: 2017-01-04 15:10 > Duration: 11 seconds. > Result: OK > Message: OK > Exit Code: 0 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.am_fixes_gset-update-return-value.7cd82bb; make test ==> hamcrest (compile) ==> hamcrest (post_compile) ==> develop.4541303.am_fixes_gset-update-return-value.7cd82bb (compile) ./rebar eunit skip_deps=true ==> develop.4541303.am_fixes_gset-update-return-value.7cd82bb (eunit) Compiled src/riak_pb_kv_codec.erl Compiled src/riak_pb_codec.erl Compiled src/riak_pb_dt_codec.erl Compiled src/riak_pb_search_codec.erl Compiled src/riak_pb_messages.erl Compiled src/riak_pb.erl Compiled src/riak_dt_pb.erl Compiled src/riak_ttb_codec.erl Compiled src/riak_yokozuna_pb.erl Compiled src/riak_pb_ts_codec.erl Compiled src/riak_ts_pb.erl Compiled src/riak_search_pb.erl Compiled test/encoding_test.erl Compiled test/riak_pb_dt_codec_tests.erl Compiled src/riak_kv_pb.erl Compiled test/bucket_props_codec_eqc.erl ======================== EUnit ======================== riak_pb_kv_codec: encode_apl_ann_test (module 'riak_pb_kv_codec')...[0.001 s] ok module 'riak_ttb_codec' module 'riak_pb_codec' riak_pb_codec: record_test...[0.010 s] ok riak_pb_codec: optional_booleans_test...[0.004 s] ok riak_pb_codec: empty_atoms_test...ok riak_pb_codec: mixed_strings_test...ok [done in 0.026 s] module 'riak_pb_messages' module 'riak_dt_pb' module 'riak_pb' module 'riak_pb_ts_codec' riak_pb_ts_codec: encode_cells_test...ok riak_pb_ts_codec: encode_row_test...ok riak_pb_ts_codec: encode_rows_test...ok riak_pb_ts_codec: encode_field_type_test...ok riak_pb_ts_codec: decode_cell_test...ok riak_pb_ts_codec: decode_cells_test...ok riak_pb_ts_codec: decode_rows_test...ok [done in 0.021 s] module 'riak_search_pb' module 'riak_ts_pb' module 'riak_pb_dt_codec' module 'riak_pb_dt_codec_tests' riak_pb_dt_codec_tests: operation_type_gset_test...ok riak_pb_dt_codec_tests: decode_operation_gset_test...ok riak_pb_dt_codec_tests: decode_fetch_response_gset_test...ok riak_pb_dt_codec_tests: decode_update_response_test...ok riak_pb_dt_codec_tests: encode_fetch_response_gset_test...ok riak_pb_dt_codec_tests: encode_update_request_gset_test...ok riak_pb_dt_codec_tests: encode_update_response_gset_test...ok [done in 0.021 s] [done in 0.021 s] module 'riak_kv_pb' module 'encoding_test' encoding_test:9: pb_test_ (content encode decode)...ok encoding_test:39: pb_test_ (deleted header encode decode)...ok encoding_test:59: pb_test_ (indexes encode decode)...ok encoding_test:73: pb_test_ (empty content encode decode)...ok encoding_test:85: pb_test_ (empty repeated metas are removed/ignored)...ok encoding_test:97: pb_test_ (riak_dt-dtfetchreq-encode-decode)...ok encoding_test:113: pb_test_ (msg code encode decode)...ok [done in 0.021 s] module 'riak_pb_search_codec' bucket_props_codec_eqc:36: bucket_codec_test_ (module 'bucket_props_codec_eqc').......................................................................................................(x10)....................................................................................................(x100)...................................................................................(x10)...(x1)......... Time limit reached: 4.0 seconds. OK, passed 9439 tests [4.941 s] ok module 'riak_yokozuna_pb' ======================================================= All 27 tests passed. =INFO REPORT==== 4-Jan-2017::15:10:31 === application: inets exited: killed type: temporary ``` --------------------------------------------------
:white_check_mark: MAKE_XREF

> Started at: 2017-01-04 15:10 > Duration: 3 seconds. > Result: OK > Message: OK > Exit Code: 0 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.am_fixes_gset-update-return-value.7cd82bb; make xref ==> hamcrest (compile) ==> hamcrest (post_compile) ==> develop.4541303.am_fixes_gset-update-return-value.7cd82bb (compile) ./rebar xref skip_deps=true ==> develop.4541303.am_fixes_gset-update-return-value.7cd82bb (xref) ``` --------------------------------------------------
:white_check_mark: MAKE_DIALYZER

> Started at: 2017-01-04 15:10 > Duration: 117 seconds. > Result: OK > Message: OK > Exit Code: 0 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.am_fixes_gset-update-return-value.7cd82bb; make dialyzer ==> hamcrest (compile) ==> hamcrest (post_compile) ==> develop.4541303.am_fixes_gset-update-return-value.7cd82bb (compile) Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes done (passed successfully) yes done (passed successfully) Creating PLT .local_dialyzer_plt ... Unknown functions: application:get_env/2 erlang:get_module_info/1 erlang:get_module_info/2 erlang:is_process_alive/1 gb_sets:is_element/2 gb_sets:is_empty/1 gb_sets:is_set/1 ordsets:is_element/2 ordsets:is_set/1 ordsets:size/1 re:run/2 sets:is_element/2 sets:is_set/1 sets:size/1 string:equal/2 string:right/2 string:str/2 done in 0m0.22s done (passed successfully) ==> develop.4541303.am_fixes_gset-update-return-value.7cd82bb (dialyzer) ``` --------------------------------------------------
:white_large_square: 0 of 2 Code reviews from organization basho
lukebakken commented 7 years ago

I'm assuming you'll make Travis happy before shipping 😺

thumbot commented 7 years ago
am/fixes/gset-update-return-value 38f5d1d :arrow_right: develop 4541303 :white_check_mark: completed
Looks good! :+1:
:white_check_mark: MERGE

> Started at: 2017-01-05 07:53 > Duration: 1 seconds. > Result: OK > Message: Merge Success: am/fixes/gset-update-return-value 38f5d1d57b86f2931b73f362b3e6e6cae6b4e06f onto target branch: develop 45413035823273a96ab0732610f25890986da88c > Exit Code: OK > :page_facing_up:

``` Updating 4541303..38f5d1d Fast-forward (no commit created; -m option ignored) include/riak_ts_pb.hrl | 4 ++-- src/riak_pb_dt_codec.erl | 6 ++++-- src/riak_ts_pb.erl | 40 ++++++++++++++++++++-------------------- test/riak_pb_dt_codec_tests.erl | 14 +++++++++++++- 4 files changed, 39 insertions(+), 25 deletions(-) ``` --------------------------------------------------
:white_check_mark: MAKE_CLEAN

> Started at: 2017-01-05 07:53 > Duration: 1 seconds. > Result: OK > Message: OK > Exit Code: 0 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.am_fixes_gset-update-return-value.38f5d1d; make clean ==> develop.4541303.am_fixes_gset-update-return-value.38f5d1d (clean) ``` --------------------------------------------------
:white_check_mark: MAKE_DEPS

> Started at: 2017-01-05 07:53 > Duration: 2 seconds. > Result: OK > Message: OK > Exit Code: 0 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.am_fixes_gset-update-return-value.38f5d1d; make deps ==> develop.4541303.am_fixes_gset-update-return-value.38f5d1d (get-deps) Pulling hamcrest from {git,"https://github.com/basho/hamcrest-erlang.git", {tag,"0.3.0-basho"}} Cloning into 'hamcrest'... ==> hamcrest (get-deps) ``` --------------------------------------------------
:white_check_mark: MAKE_COMPILE

> Started at: 2017-01-05 07:53 > Duration: 5 seconds. > Result: OK > Message: OK > Exit Code: 0 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.am_fixes_gset-update-return-value.38f5d1d; make compile ==> hamcrest (compile) Compiled src/hamcrest.erl Compiled src/hamcrest_term.erl Compiled src/hamcrest_matchers.erl ==> hamcrest (post_compile) ==> develop.4541303.am_fixes_gset-update-return-value.38f5d1d (compile) Compiled src/riak_pb_kv_codec.erl Compiled src/riak_pb_codec.erl Compiled src/riak_pb_search_codec.erl Compiled src/riak_pb_messages.erl Compiled src/riak_pb_dt_codec.erl Compiled src/riak_dt_pb.erl Compiled src/riak_pb.erl Compiled src/riak_ttb_codec.erl Compiled src/riak_yokozuna_pb.erl Compiled src/riak_pb_ts_codec.erl Compiled src/riak_ts_pb.erl Compiled src/riak_search_pb.erl Compiled src/riak_kv_pb.erl ``` --------------------------------------------------
:white_check_mark: MAKE_TEST

> Started at: 2017-01-05 07:53 > Duration: 12 seconds. > Result: OK > Message: OK > Exit Code: 0 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.am_fixes_gset-update-return-value.38f5d1d; make test ==> hamcrest (compile) ==> hamcrest (post_compile) ==> develop.4541303.am_fixes_gset-update-return-value.38f5d1d (compile) ./rebar eunit skip_deps=true ==> develop.4541303.am_fixes_gset-update-return-value.38f5d1d (eunit) Compiled src/riak_pb_kv_codec.erl Compiled src/riak_pb_codec.erl Compiled src/riak_pb_dt_codec.erl Compiled src/riak_pb_search_codec.erl Compiled src/riak_pb_messages.erl Compiled src/riak_dt_pb.erl Compiled src/riak_pb.erl Compiled src/riak_ttb_codec.erl Compiled src/riak_yokozuna_pb.erl Compiled src/riak_ts_pb.erl Compiled src/riak_pb_ts_codec.erl Compiled src/riak_search_pb.erl Compiled test/encoding_test.erl Compiled test/riak_pb_dt_codec_tests.erl Compiled src/riak_kv_pb.erl Compiled test/bucket_props_codec_eqc.erl ======================== EUnit ======================== riak_pb_kv_codec: encode_apl_ann_test (module 'riak_pb_kv_codec')...[0.001 s] ok module 'riak_ttb_codec' module 'riak_pb_codec' riak_pb_codec: record_test...[0.011 s] ok riak_pb_codec: optional_booleans_test...[0.004 s] ok riak_pb_codec: empty_atoms_test...ok riak_pb_codec: mixed_strings_test...ok [done in 0.027 s] module 'riak_pb_messages' module 'riak_dt_pb' module 'riak_pb' module 'riak_pb_ts_codec' riak_pb_ts_codec: encode_cells_test...ok riak_pb_ts_codec: encode_row_test...ok riak_pb_ts_codec: encode_rows_test...ok riak_pb_ts_codec: encode_field_type_test...ok riak_pb_ts_codec: decode_cell_test...ok riak_pb_ts_codec: decode_cells_test...ok riak_pb_ts_codec: decode_rows_test...ok [done in 0.021 s] module 'riak_search_pb' module 'riak_ts_pb' module 'riak_pb_dt_codec' module 'riak_pb_dt_codec_tests' riak_pb_dt_codec_tests: operation_type_gset_test...ok riak_pb_dt_codec_tests: decode_operation_gset_test...ok riak_pb_dt_codec_tests: decode_fetch_response_gset_test...ok riak_pb_dt_codec_tests: decode_update_response_test...ok riak_pb_dt_codec_tests: encode_fetch_response_gset_test...ok riak_pb_dt_codec_tests: encode_update_request_gset_test...ok riak_pb_dt_codec_tests: encode_update_response_gset_test...ok [done in 0.021 s] [done in 0.021 s] module 'riak_kv_pb' module 'encoding_test' encoding_test:9: pb_test_ (content encode decode)...ok encoding_test:39: pb_test_ (deleted header encode decode)...ok encoding_test:59: pb_test_ (indexes encode decode)...ok encoding_test:73: pb_test_ (empty content encode decode)...ok encoding_test:85: pb_test_ (empty repeated metas are removed/ignored)...ok encoding_test:97: pb_test_ (riak_dt-dtfetchreq-encode-decode)...ok encoding_test:113: pb_test_ (msg code encode decode)...ok [done in 0.021 s] module 'riak_pb_search_codec' bucket_props_codec_eqc:36: bucket_codec_test_ (module 'bucket_props_codec_eqc').......................................................................................................(x10)....................................................................................................(x100).................................................................................(x10)......(x1)........ Time limit reached: 4.0 seconds. OK, passed 9268 tests [5.566 s] ok module 'riak_yokozuna_pb' ======================================================= All 27 tests passed. =INFO REPORT==== 5-Jan-2017::07:53:38 === application: inets exited: killed type: temporary ``` --------------------------------------------------
:white_check_mark: MAKE_XREF

> Started at: 2017-01-05 07:53 > Duration: 3 seconds. > Result: OK > Message: OK > Exit Code: 0 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.am_fixes_gset-update-return-value.38f5d1d; make xref ==> hamcrest (compile) ==> hamcrest (post_compile) ==> develop.4541303.am_fixes_gset-update-return-value.38f5d1d (compile) ./rebar xref skip_deps=true ==> develop.4541303.am_fixes_gset-update-return-value.38f5d1d (xref) ``` --------------------------------------------------
:white_check_mark: MAKE_DIALYZER

> Started at: 2017-01-05 07:53 > Duration: 124 seconds. > Result: OK > Message: OK > Exit Code: 0 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.am_fixes_gset-update-return-value.38f5d1d; make dialyzer ==> hamcrest (compile) ==> hamcrest (post_compile) ==> develop.4541303.am_fixes_gset-update-return-value.38f5d1d (compile) Checking whether the PLT /home/ubuntu/.combo_dialyzer_plt is up-to-date... yes done (passed successfully) yes done (passed successfully) Creating PLT .local_dialyzer_plt ... Unknown functions: application:get_env/2 erlang:get_module_info/1 erlang:get_module_info/2 erlang:is_process_alive/1 gb_sets:is_element/2 gb_sets:is_empty/1 gb_sets:is_set/1 ordsets:is_element/2 ordsets:is_set/1 ordsets:size/1 re:run/2 sets:is_element/2 sets:is_set/1 sets:size/1 string:equal/2 string:right/2 string:str/2 done in 0m0.23s done (passed successfully) ==> develop.4541303.am_fixes_gset-update-return-value.38f5d1d (dialyzer) ``` --------------------------------------------------
:white_large_square: 0 of 2 Code reviews from organization basho
lukebakken commented 7 years ago

:shipit:

alexmoore commented 7 years ago

Works with latest Java client changes, merging.