basho / riak_pb

Riak Protocol Buffers Messages
Apache License 2.0
70 stars 114 forks source link

Add syntax version to .proto files #220

Closed shaneutt closed 7 years ago

shaneutt commented 7 years ago

protoc clients using libprotoc 3.0.0+ want .proto files to specify their protocol buffers syntax version.

This adds the syntax version to avoid warnings from libprotoc 3.0.0+.

thumbot commented 7 years ago

Thanks @shaneutt!

Settings ```yaml --- minimum_reviewers: 2 merge: true build_steps: - make clean - make deps - make compile - make test - make xref - make dialyzer org_mode: true timeout: 1800 ```
thumbot commented 7 years ago
develop da19df4 :arrow_right: develop 4541303 :no_entry: completed
There seems to be an issue with build step **make_compile,make_test,make_xref,make_dialyzer** ! :cloud:
:white_check_mark: MERGE

> Started at: 2017-01-05 08:35 > Duration: 1 seconds. > Result: OK > Message: Merge Success: develop da19df435a055d56597e3bdb135e271e1e9e8fe4 onto target branch: develop 45413035823273a96ab0732610f25890986da88c > Exit Code: OK > :page_facing_up:

``` Updating 4541303..da19df4 Fast-forward (no commit created; -m option ignored) src/riak.proto | 2 ++ src/riak_dt.proto | 2 ++ src/riak_dt_pb.erl | 23 +++++++++++++++++++++ src/riak_kv.proto | 2 ++ src/riak_kv_pb.erl | 52 ++++++++++++++++++++++++++++++++++++++++++++++++ src/riak_pb.erl | 18 +++++++++++++++++ src/riak_search.proto | 2 ++ src/riak_search_pb.erl | 22 ++++++++++++++++++++ src/riak_ts.proto | 2 ++ src/riak_ts_pb.erl | 39 ++++++++++++++++++++++++++++++++++++ src/riak_yokozuna.proto | 2 ++ src/riak_yokozuna_pb.erl | 11 ++++++++++ 12 files changed, 177 insertions(+) ``` --------------------------------------------------
:white_check_mark: MAKE_CLEAN

> Started at: 2017-01-05 08:35 > Duration: 1 seconds. > Result: OK > Message: OK > Exit Code: 0 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.develop.da19df4; make clean ==> develop.4541303.develop.da19df4 (clean) ``` --------------------------------------------------
:white_check_mark: MAKE_DEPS

> Started at: 2017-01-05 08:35 > Duration: 1 seconds. > Result: OK > Message: OK > Exit Code: 0 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.develop.da19df4; make deps ==> develop.4541303.develop.da19df4 (get-deps) Pulling hamcrest from {git,"https://github.com/basho/hamcrest-erlang.git", {tag,"0.3.0-basho"}} Cloning into 'hamcrest'... ==> hamcrest (get-deps) ``` --------------------------------------------------
:no_entry: MAKE_COMPILE

> Started at: 2017-01-05 08:35 > Duration: 2 seconds. > Result: ERROR > Message: Step make_compile Failed! > Exit Code: 2 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.develop.da19df4; make compile ==> hamcrest (compile) Compiled src/hamcrest.erl Compiled src/hamcrest_term.erl Compiled src/hamcrest_matchers.erl ==> hamcrest (post_compile) ==> develop.4541303.develop.da19df4 (compile) Compiled src/riak_pb_kv_codec.erl Compiled src/riak_pb_codec.erl Compiled src/riak_pb_search_codec.erl Compiled src/riak_pb_messages.erl Compiled src/riak_pb_dt_codec.erl src/riak_dt_pb.erl:4148: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4157: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4192: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4227: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4265: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4278: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4287: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4306: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4318: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4330: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4356: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4379: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4403: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4445: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4488: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4501: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4514: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4523: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4534: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4546: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4557: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4569: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4577: attribute 'dialyzer' after function definitions Compiling src/riak_dt_pb.erl failed: ERROR: compile failed while processing /tmp/thumbs/develop.4541303.develop.da19df4: rebar_abort make: *** [erl_compile] Error 1 ``` --------------------------------------------------
:no_entry: MAKE_TEST

> Started at: 2017-01-05 08:35 > Duration: 1 seconds. > Result: ERROR > Message: Step make_test Failed! > Exit Code: 2 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.develop.da19df4; make test ==> hamcrest (compile) ==> hamcrest (post_compile) ==> develop.4541303.develop.da19df4 (compile) src/riak_dt_pb.erl:4148: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4157: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4192: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4227: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4265: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4278: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4287: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4306: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4318: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4330: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4356: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4379: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4403: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4445: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4488: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4501: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4514: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4523: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4534: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4546: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4557: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4569: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4577: attribute 'dialyzer' after function definitions Compiling src/riak_dt_pb.erl failed: ERROR: compile failed while processing /tmp/thumbs/develop.4541303.develop.da19df4: rebar_abort make: *** [erl_compile] Error 1 ``` --------------------------------------------------
:no_entry: MAKE_XREF

> Started at: 2017-01-05 08:35 > Duration: 2 seconds. > Result: ERROR > Message: Step make_xref Failed! > Exit Code: 2 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.develop.da19df4; make xref ==> hamcrest (compile) ==> hamcrest (post_compile) ==> develop.4541303.develop.da19df4 (compile) src/riak_dt_pb.erl:4148: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4157: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4192: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4227: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4265: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4278: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4287: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4306: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4318: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4330: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4356: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4379: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4403: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4445: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4488: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4501: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4514: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4523: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4534: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4546: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4557: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4569: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4577: attribute 'dialyzer' after function definitions Compiling src/riak_dt_pb.erl failed: ERROR: compile failed while processing /tmp/thumbs/develop.4541303.develop.da19df4: rebar_abort make: *** [erl_compile] Error 1 ``` --------------------------------------------------
:no_entry: MAKE_DIALYZER

> Started at: 2017-01-05 08:35 > Duration: 1 seconds. > Result: ERROR > Message: Step make_dialyzer Failed! > Exit Code: 2 > :page_facing_up:

``` cd /tmp/thumbs/develop.4541303.develop.da19df4; make dialyzer ==> hamcrest (compile) ==> hamcrest (post_compile) ==> develop.4541303.develop.da19df4 (compile) src/riak_dt_pb.erl:4148: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4157: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4192: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4227: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4265: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4278: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4287: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4306: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4318: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4330: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4356: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4379: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4403: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4445: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4488: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4501: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4514: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4523: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4534: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4546: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4557: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4569: attribute 'dialyzer' after function definitions src/riak_dt_pb.erl:4577: attribute 'dialyzer' after function definitions Compiling src/riak_dt_pb.erl failed: ERROR: compile failed while processing /tmp/thumbs/develop.4541303.develop.da19df4: rebar_abort make: *** [erl_compile] Error 1 ``` --------------------------------------------------
:white_large_square: 0 of 2 Code reviews from organization basho
lukebakken commented 7 years ago

The addition of -dialyzer broke the build. I am going to close this as it's just a warning that is emitted, right, not an error?