search

basho / riak_pb

Riak Protocol Buffers Messages
Apache License 2.0
70 stars 114 forks source link

erlang 20 eunit failure #226

Closed mathiasertl closed 6 years ago

mathiasertl commented 6 years ago

When I run the eunit tests (e.g. using make test), I get the following error:

==> erlang-riak-protobuf (eunit)
Compiled src/riak_pb_kv_codec.erl
Compiled src/riak_pb_dt_codec.erl
src/riak_pb_codec.erl:33: export_all flag enabled - all functions will be exported
Compiling src/riak_pb_codec.erl failed:
ERROR: eunit failed while processing /home/mati/repositories/erlang-riak-protobuf: rebar_abort
tools.mk:38: recipe for target 'test' failed
make: *** [test] Error 1

This only occurs with Erlang 20. Googling the error yields some similar issues (e.g. this one) that seem to have it solved already.

martincox commented 6 years ago

It's because compiler option warn_export_all became enabled by default in OTP20. Adding -compile(nowarn_export_all) will suppress the errors, which I guess is fine for use in test modules or ifdef test blocks.

martincox commented 6 years ago

Fixed by #227

martincox commented 6 years ago

Has been upgraded to OTP20/rebar3 in develop-3.0 bf5449e1f660c83041c73387b4a090e8b92da6c1