search

basho / riak_pipe

Riak Pipelines
Apache License 2.0
162 stars 60 forks source link

Use modfun tuples instead of anonymous funs (AZ561) #32

Closed beerriot closed 13 years ago

beerriot commented 13 years ago

This is the second half of the migration to modfun tuples for chash and nval Pipe parameters. It includes the first half, which was made on the 1.0 branch for inclusion in 1.0.2. This makes the diff a little awkward, but the important commits in this PR are the last two: d538ca1f and 8cdb6fda.

The riak_pipe_fun:compat_apply/2 magic was necessary to ensure a stable rolling upgrade for Riak KV's MapReduce pipes. It should be general enough to be used by other functions, if necessary.

kellymclaughlin commented 13 years ago

I noticed there are some commits from Jared included. Probably because the branch was branched from 1.0, but is being merged to master. Might just want to rebase this branch from master after merging the 1.0.x commit and before merging to try and avoid some potential merge conflicts.

beerriot commented 13 years ago

@kellymclaughlin: done: https://github.com/basho/riak_pipe/pull/33